----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59585/#review176169 -----------------------------------------------------------
Fix it, then Ship it! src/tests/slave_recovery_tests.cpp Lines 806 (patched) <https://reviews.apache.org/r/59585/#comment249531> s/that/that when/ src/tests/slave_recovery_tests.cpp Lines 847 (patched) <https://reviews.apache.org/r/59585/#comment249532> maybe instead of ignoring subsequent updates test that no further updates are sent as a result of this change. src/tests/slave_recovery_tests.cpp Lines 859 (patched) <https://reviews.apache.org/r/59585/#comment249533> if you want to follow the above advice, you need to ensure ack is checkpointed. src/tests/slave_recovery_tests.cpp Lines 882 (patched) <https://reviews.apache.org/r/59585/#comment249534> // The first attempt by the executor to re-register is dropped so that the agent will retry the reconnect. - Vinod Kone On May 26, 2017, 12:21 a.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59585/ > ----------------------------------------------------------- > > (Updated May 26, 2017, 12:21 a.m.) > > > Review request for mesos, Anand Mazumdar, Greg Mann, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > This tests that the retries occur if the agent does not receive > a re-registration from the executor within the timeout interval. > > > Diffs > ----- > > src/tests/slave_recovery_tests.cpp 0aa87f534fbc655e3f1aa2ab7f56a1b6be7a8755 > > > Diff: https://reviews.apache.org/r/59585/diff/1/ > > > Testing > ------- > > Ran in repetition. > > > Thanks, > > Benjamin Mahler > >
