----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58719/#review176267 -----------------------------------------------------------
src/cli_new/lib/cli/http.py Lines 42 (patched) <https://reviews.apache.org/r/58719/#comment249639> We should have a constant for the timeout, not just a hard coded number 5. Since this is a "temporary" commit until we have a more robust set of library calls for doing http requests though, I think it should be OK to leave it as is. src/cli_new/lib/cli/http.py Lines 73-74 (patched) <https://reviews.apache.org/r/58719/#comment249640> The space at the end of the first line should be at the beginning of the second line. src/cli_new/lib/cli/http.py Lines 77 (patched) <https://reviews.apache.org/r/58719/#comment249638> We should probably have a constant for this 0.1 instead of hardcoding it (or allow it to be passed as a parameter). Since this is a "temporary" commit until we have a more robust set of library calls for doing http requests though, I think it should be OK to leave it as is. - Kevin Klues On April 25, 2017, 10:18 p.m., Armand Grillet wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58719/ > ----------------------------------------------------------- > > (Updated April 25, 2017, 10:18 p.m.) > > > Review request for mesos and Kevin Klues. > > > Repository: mesos > > > Description > ------- > > This will be used by future plugins and tests. > > > Diffs > ----- > > src/cli_new/lib/cli/http.py PRE-CREATION > > > Diff: https://reviews.apache.org/r/58719/diff/1/ > > > Testing > ------- > > Tested manually, PEP8 and Pylint used to make sure that the code style is > correct. > > > Thanks, > > Armand Grillet > >
