----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58720/#review176357 -----------------------------------------------------------
Fix it, then Ship it! I am just waiting on two things before committing this: 1) A ShipIt for https://reviews.apache.org/r/59634 so I can land that before this one. 2) Andrei, to either drop his issue or comment on why he thinks we should follow his suggestion. src/cli_new/lib/cli/tests/base.py Lines 216 (patched) <https://reviews.apache.org/r/58720/#comment249747> My `sys.platform` was `linux2`, so I changed this to: ``` # Disabling systemd support on Linux to run without sudo. if "linux" in sys.platform and "systemd_enable_support" not in flags: flags["systemd_enable_support"] = "false" ``` I will commit this without needing another round of reviews. - Kevin Klues On May 30, 2017, 5:25 p.m., Armand Grillet wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58720/ > ----------------------------------------------------------- > > (Updated May 30, 2017, 5:25 p.m.) > > > Review request for mesos and Kevin Klues. > > > Bugs: MESOS-7283 > https://issues.apache.org/jira/browse/MESOS-7283 > > > Repository: mesos > > > Description > ------- > > This infrastructure includes the ability to bring up a test cluster to > run the CLI against. Future unit tests will use this infrastructure to > test their commands against a running mesos cluster. The tests require > some binaries created when building Mesos. > > > Diffs > ----- > > src/cli_new/lib/cli/tests/__init__.py PRE-CREATION > src/cli_new/lib/cli/tests/base.py PRE-CREATION > src/cli_new/lib/cli/tests/constants.py PRE-CREATION > src/cli_new/lib/cli/tests/tests.py PRE-CREATION > src/cli_new/pip-requirements.txt 28613e56a5c6d5c7606a7e58d6125b0c34748e83 > src/cli_new/tests/main.py dff5d48b0ddae87960a78f9d05e4ae597912f1f6 > > > Diff: https://reviews.apache.org/r/58720/diff/15/ > > > Testing > ------- > > PEP8 and Pylint used to make sure that the code style is correct. Manuel test: > > $ cd src/cli_new > $ ./bootstrap > $ source activate > > (mesos-cli) $ mesos-cli-tests > > > Thanks, > > Armand Grillet > >