----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59525/#review176443 -----------------------------------------------------------
Patch looks great! Reviews applied: [59453, 58955, 58964, 59099, 59100, 59101, 59147, 59525] Passed command: support\windows-build.bat - Mesos Reviewbot Windows On May 31, 2017, 12:41 p.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59525/ > ----------------------------------------------------------- > > (Updated May 31, 2017, 12:41 p.m.) > > > Review request for mesos, Adam B and Greg Mann. > > > Bugs: MESOS-7416 > https://issues.apache.org/jira/browse/MESOS-7416 > > > Repository: mesos > > > Description > ------- > > Adds support of the `VIEW_ROLE` ACL to the results generated by > the `/slaves` as well as the `GET_AGENTS` API v1 call. This means > that calls to this endpoint (API call) will hide roles that the > user making the request is not authorized to see. > > > Diffs > ----- > > src/master/http.cpp eb80830fa003ad8f58243d3dc4cec9e03285e96f > src/master/master.hpp 89d0790fd5fea59e74276f462581fe0073594732 > > > Diff: https://reviews.apache.org/r/59525/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >