----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59659/#review176463 -----------------------------------------------------------
Fix it, then Ship it! - Can we do a sweep for the `Framework`/`Executor` structs too? I haven't had a look later in the chain yet. - Can we do a similar cleanup for the Master header file too? src/slave/slave.hpp Lines 507-508 (original), 507-508 (patched) <https://reviews.apache.org/r/59659/#comment249824> Nit: Can we move it after the constructor declaration now that it no longer needs to be private. This would help readability. - Anand Mazumdar On May 30, 2017, 11:14 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59659/ > ----------------------------------------------------------- > > (Updated May 30, 2017, 11:14 p.m.) > > > Review request for mesos, Anand Mazumdar and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Used `delete` for `Slave` copy constructor and assignment operator. > > > Diffs > ----- > > src/slave/slave.hpp 77fb93abc701cd34b69c75b6219c219fdb784a67 > > > Diff: https://reviews.apache.org/r/59659/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >