----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59696/#review176566 -----------------------------------------------------------
Fix it, then Ship it! src/tests/containerizer/nvidia_gpu_isolator_tests.cpp Lines 423-425 (patched) <https://reviews.apache.org/r/59696/#comment249949> Same comment here, would be nice if we could run this without needing the gpu isolator. - Benjamin Mahler On May 31, 2017, 9:39 p.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59696/ > ----------------------------------------------------------- > > (Updated May 31, 2017, 9:39 p.m.) > > > Review request for mesos, Anand Mazumdar and Benjamin Mahler. > > > Bugs: MESOS-7576 > https://issues.apache.org/jira/browse/MESOS-7576 > > > Repository: mesos > > > Description > ------- > > Added test to verify GPU filtering with '--filter_gpu_resources=false'. > > > Diffs > ----- > > src/tests/containerizer/nvidia_gpu_isolator_tests.cpp > 9a78ae65c1cd414b5093b54ff51724e31e31c9d3 > > > Diff: https://reviews.apache.org/r/59696/diff/1/ > > > Testing > ------- > > $ GTEST_FILTER="" make -j check > $ sudo GTEST_FILTER="*GPUFilterDisabled*" src/mesos-tests > ``` > [==========] Running 1 test from 1 test case. > [----------] Global test environment set-up. > [----------] 1 test from NvidiaGpuTest > [ RUN ] NvidiaGpuTest.ROOT_CGROUPS_NVIDIA_GPU_GPUFilterDisabled > Executing pre-exec command > '{"arguments":["mesos-containerizer","mount","--help=false","--operation=make-rslave","--path=\/"],"shell":false,"value":"\/home\/klueska\/projects\/mesos\/build\/src\/mesos-containerizer"}' > I0530 19:45:29.213250 33200 exec.cpp:162] Version: 1.4.0 > I0530 19:45:29.228093 33183 exec.cpp:237] Executor registered on agent > 5c94c185-8f83-4e70-af3e-2bebcb49a310-S0 > Received SUBSCRIBED event > Subscribed executor on core-dev > Received LAUNCH event > Starting task dabc46f6-2866-474b-a1f5-3419a7b5927d > Running '/home/klueska/projects/mesos/build/src/mesos-containerizer launch > <POSSIBLY-SENSITIVE-DATA>' > Forked command at 33228 > Command exited with status 0 (pid: 33228) > I0530 19:45:29.424254 33195 exec.cpp:435] Executor asked to shutdown > Received SHUTDOWN event > Shutting down > [ OK ] NvidiaGpuTest.ROOT_CGROUPS_NVIDIA_GPU_VerifyGPUFilterDisabled > (9111 ms) > [----------] 1 test from NvidiaGpuTest (9113 ms total) > > [----------] Global test environment tear-down > [==========] 1 test from 1 test case ran. (9146 ms total) > [ PASSED ] 1 test. > ``` > > > Thanks, > > Kevin Klues > >
