> On June 1, 2017, 2:03 a.m., Jie Yu wrote: > > include/mesos/mesos.proto > > Lines 1453 (patched) > > <https://reviews.apache.org/r/59082/diff/2/?file=1735334#file1735334line1453> > > > > Given we already have `provider_id` in `Resource`. Do we still need > > that?
Good point! When I started implementing this, I wasn't too sure if resource of resource providers will be mixed with resources of agents. Now I know that this won't be that case. Will discard and change #59681 accordingly. - Jan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59082/#review176559 ----------------------------------------------------------- On May 31, 2017, 12:02 p.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59082/ > ----------------------------------------------------------- > > (Updated May 31, 2017, 12:02 p.m.) > > > Review request for mesos, Benjamin Bannier and Jie Yu. > > > Bugs: MESOS-7593 > https://issues.apache.org/jira/browse/MESOS-7593 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > include/mesos/mesos.proto b063ddaca60398db0ca8ef8a6a41e472b9f4a404 > include/mesos/v1/mesos.proto bc7dbe0d99de6e5a23b842751fce43896a6fcce9 > > > Diff: https://reviews.apache.org/r/59082/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
