----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59600/#review176751 -----------------------------------------------------------
docs/configuration.md Lines 1853 (patched) <https://reviews.apache.org/r/59600/#comment250221> The example JSON isn't a `ResourceProviderInfo`. Would a `ResourceProviderInfo` even make sense here? I.e. how does this provide enough information for an agent to decide which standalone container (containing the actual resource provider) to launch? Also, `ResourceProviderInfo` contains a `resources` field which IMO shouldn't be set here. Instead the resources should be reported by the resource provider when subscribing with a master. - Jan Schlicht On May 26, 2017, 3:12 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59600/ > ----------------------------------------------------------- > > (Updated May 26, 2017, 3:12 a.m.) > > > Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Joseph Wu, and > Jan Schlicht. > > > Bugs: MESOS-7571 > https://issues.apache.org/jira/browse/MESOS-7571 > > > Repository: mesos > > > Description > ------- > > Added `--resource_providers` flag to the agent. > > > Diffs > ----- > > docs/configuration.md 59e1bbe7502c7f55fb3fb3167ccdccc1294e6db7 > include/mesos/type_utils.hpp c7872c0cd7f19d923e8be1f33a775d5eb17a0cf7 > src/common/parse.hpp 64eabf89f81a6708cfac89081e0d9f9586721693 > src/common/type_utils.cpp 5f8e72b97d6766f9729079f6c6c013bc117cedb9 > src/slave/flags.hpp b66995630f89dfb95a6d0cf66efc5d7590e90cbc > src/slave/flags.cpp 0c8276e425a6a7d22ee68edc6cc25b331635ec44 > > > Diff: https://reviews.apache.org/r/59600/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
