----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59294/#review177027 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/network/port_mapping.cpp Lines 2235-2239 (patched) <https://reviews.apache.org/r/59294/#comment250604> `Bytes::parse()` handles units as binary units, but AFAIK `tc` is showing rate with SI units. At least without `-iec` option. Won't we think that egress rate is higher than it actually is? Am I missing something here? - Ilya Pronin On May 26, 2017, 7:23 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59294/ > ----------------------------------------------------------- > > (Updated May 26, 2017, 7:23 p.m.) > > > Review request for mesos, Dmitry Zhuk, Ilya Pronin, and Jie Yu. > > > Bugs: MESOS-7508 > https://issues.apache.org/jira/browse/MESOS-7508 > > > Repository: mesos > > > Description > ------- > > Add support to isolators/port_mapping for optionally scaling egress bandwidth > with CPU and with minimum and maximum limits. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/network/port_mapping.hpp > 9d38289c7161d5e931053b587d115684ccc44c94 > src/slave/containerizer/mesos/isolators/network/port_mapping.cpp > cd008aaebcd42554a9a81d2b059269546f59c966 > src/slave/flags.hpp b66995630f89dfb95a6d0cf66efc5d7590e90cbc > src/slave/flags.cpp 0c8276e425a6a7d22ee68edc6cc25b331635ec44 > src/tests/containerizer/port_mapping_tests.cpp > d062f2f6bcf7b44dbcde951cdca23b0a2cd42115 > > > Diff: https://reviews.apache.org/r/59294/diff/2/ > > > Testing > ------- > > # added a new test > $ make check > > > Thanks, > > Ian Downes > >
