----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59930/#review177535 -----------------------------------------------------------
Patch looks great! Reviews applied: [59930] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On June 8, 2017, 11:06 p.m., Charles Raimbert wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59930/ > ----------------------------------------------------------- > > (Updated June 8, 2017, 11:06 p.m.) > > > Review request for mesos, Jason Lai, Jie Yu, and Zhitao Li. > > > Repository: mesos > > > Description > ------- > > The filesystem/linux isolator currently creates all bind mount volumes as RW, > even if a volume mode is set as RO. > > The TODO in the isolator code helps to spot the missing capability: > https://github.com/apache/mesos/blob/master/src/slave/containerizer/mesos/isolators/filesystem/linux.cpp#L587 > ` > // TODO(jieyu): Consider the mode in the volume. > ` > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/filesystem/linux.cpp > 69804eec61467ae0fd95dfdf53a08875e27a0bca > src/tests/containerizer/linux_filesystem_isolator_tests.cpp > 803758c1437b21df9f25ad7e994298e89de44cbe > > > Diff: https://reviews.apache.org/r/59930/diff/1/ > > > Testing > ------- > > Test cases for RW and RO bind mount volumes have been added, by following the > filesystem/linux isolator's existing testing pattern. > > > Thanks, > > Charles Raimbert > >