----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59987/#review177586 -----------------------------------------------------------
Patch looks great! Reviews applied: [59987] Passed command: support\windows-build.bat - Mesos Reviewbot Windows On June 12, 2017, 10:01 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59987/ > ----------------------------------------------------------- > > (Updated June 12, 2017, 10:01 a.m.) > > > Review request for mesos, Anand Mazumdar and Zhitao Li. > > > Repository: mesos > > > Description > ------- > > Map is a feature of proto2 syntax, but it can only be compiled > with proto3 compiler, see the following discussion for details: > https://groups.google.com/forum/#!topic/protobuf/p4WxcplrlA4 > We have already upgraded the compiler from 2.6.1 to 3.3.0 in > MESOS-7228, however, to use protobuf map in Mesos code, we also > need to add the protobuf map support to the code in Mesos for > converting protobuf message to JSON object and parsing JSON > object as protobuf message, that is what I have done in this patch. > > > Diffs > ----- > > 3rdparty/stout/include/stout/protobuf.hpp > 2735354256f35d2792c3690bcc8fc61c3f6d9524 > > > Diff: https://reviews.apache.org/r/59987/diff/1/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >