> On June 12, 2017, 11:44 p.m., Zhitao Li wrote: > > 3rdparty/stout/tests/protobuf_tests.cpp > > Lines 614 (patched) > > <https://reviews.apache.org/r/59989/diff/1/?file=1747825#file1747825line614> > > > > Mind explaining how the magical numerical numbers are picked?
Sure, I have added a comment for that. Actually I use the same set of large number with another test `ProtobufTest.JsonifyLargeIntegers` :-) - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59989/#review177627 ----------------------------------------------------------- On June 13, 2017, 4:47 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59989/ > ----------------------------------------------------------- > > (Updated June 13, 2017, 4:47 p.m.) > > > Review request for mesos, Anand Mazumdar and Zhitao Li. > > > Repository: mesos > > > Description > ------- > > Added a test `ProtobufTest.JsonifyMap`. > > > Diffs > ----- > > 3rdparty/stout/tests/protobuf_tests.cpp > 8877e8934e0f7875bfedcfa88b491ce4b13ca44f > > > Diff: https://reviews.apache.org/r/59989/diff/2/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Qian Zhang > >
