----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59761/#review177821 -----------------------------------------------------------
src/common/parse.hpp Lines 226 (patched) <https://reviews.apache.org/r/59761/#comment251547> 2 blank lines. src/master/flags.cpp Lines 645 (patched) <https://reviews.apache.org/r/59761/#comment251548> consider using `domain` instead of `domains` here for future proofing. - Vinod Kone On June 2, 2017, 8:10 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59761/ > ----------------------------------------------------------- > > (Updated June 2, 2017, 8:10 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-7610 > https://issues.apache.org/jira/browse/MESOS-7610 > > > Repository: mesos > > > Description > ------- > > Added master and agent flags to specify domain. > > > Diffs > ----- > > docs/configuration.md ed510fa638878b71e7fcff4850152a8a8622127e > src/common/parse.hpp 64eabf89f81a6708cfac89081e0d9f9586721693 > src/master/flags.hpp 8a9bd2dfa513f1de85dab2cc3cc1d78e80293837 > src/master/flags.cpp ca5f02c728a9f39abbbee59fa169f95d20c69d3d > src/slave/flags.hpp 2f9d52e94c2c31e95208cd8b0640a5de2d2a61fd > src/slave/flags.cpp 93c8ffb5c822cf6c99071be7aca52a6b3d187619 > > > Diff: https://reviews.apache.org/r/59761/diff/1/ > > > Testing > ------- > > `make check` > > > Thanks, > > Neil Conway > >
