----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59950/#review178063 -----------------------------------------------------------
Fix it, then Ship it! src/tests/containerizer/cni_isolator_tests.cpp Lines 1266 (patched) <https://reviews.apache.org/r/59950/#comment251857> s/`DefaultExecutor`/default executor src/tests/containerizer/cni_isolator_tests.cpp Lines 1267 (patched) <https://reviews.apache.org/r/59950/#comment251858> s/vs/or? src/tests/containerizer/cni_isolator_tests.cpp Lines 1270 (patched) <https://reviews.apache.org/r/59950/#comment251852> s/`DefaultExecutor`/default executor, s/run against/use src/tests/containerizer/cni_isolator_tests.cpp Lines 1335 (patched) <https://reviews.apache.org/r/59950/#comment251856> s/EXPECT_NE/ASSERT_NE Otherwise, this can crash the entire test suite. src/tests/containerizer/cni_isolator_tests.cpp Lines 1392 (patched) <https://reviews.apache.org/r/59950/#comment251855> Kill this. src/tests/containerizer/cni_isolator_tests.cpp Lines 1394-1396 (patched) <https://reviews.apache.org/r/59950/#comment251853> hmm, this would be flaky. We need to do this before sending the accept call? src/tests/containerizer/cni_isolator_tests.cpp Lines 1401 (patched) <https://reviews.apache.org/r/59950/#comment251854> Kill this. - Anand Mazumdar On June 15, 2017, 12:41 a.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59950/ > ----------------------------------------------------------- > > (Updated June 15, 2017, 12:41 a.m.) > > > Review request for mesos, Anand Mazumdar and Jie Yu. > > > Bugs: MESOS-7631 > https://issues.apache.org/jira/browse/MESOS-7631 > > > Repository: mesos > > > Description > ------- > > Added tests for `DefaultExecutor` setting `MESOS_CONTAINER_IP`. > > > Diffs > ----- > > src/tests/containerizer/cni_isolator_tests.cpp > 505439faefe991b22e6c3435274bd18d01b73251 > src/tests/mesos.hpp 48072a976cdbe6e655dc6f5f258abc6d737ed068 > > > Diff: https://reviews.apache.org/r/59950/diff/3/ > > > Testing > ------- > > make check > > [==========] Running 2 tests from 2 test cases. > [----------] Global test environment set-up. > [----------] 1 test from HostNetwork/DefaultExecutorCniTest > [ RUN ] HostNetwork/DefaultExecutorCniTest.ROOT_VerifyContainerIP/0 > I0609 18:16:12.417310 22692 executor.cpp:192] Version: 1.4.0 > I0609 18:16:12.435683 22694 default_executor.cpp:182] Received SUBSCRIBED > event > I0609 18:16:12.441695 22694 default_executor.cpp:186] Subscribed executor on > centos7 > I0609 18:16:12.442006 22694 default_executor.cpp:182] Received LAUNCH_GROUP > event > W0609 18:16:12.444447 22691 default_executor.cpp:443] Setting > `MESOS_CONTAINER_IP` to: 127.0.0.1 > I0609 18:16:12.469161 22691 default_executor.cpp:605] Successfully launched > tasks [ 34ddb6bc-bf93-42ff-aab1-cb06d25c5fc6 ] in child containers [ > 1a6e3ada-7e68-43c7-95e2-88978c055c7d.1f0a6c53-8189-4989-8dd1-4e38f28f7f5e ] > I0609 18:16:12.472266 22693 default_executor.cpp:678] Waiting for child > container > 1a6e3ada-7e68-43c7-95e2-88978c055c7d.1f0a6c53-8189-4989-8dd1-4e38f28f7f5e of > task '34ddb6bc-bf93-42ff-aab1-cb06d25c5fc6' > I0609 18:16:12.481412 22689 default_executor.cpp:182] Received ACKNOWLEDGED > event > I0609 18:16:12.575834 22694 default_executor.cpp:823] Child container > 1a6e3ada-7e68-43c7-95e2-88978c055c7d.1f0a6c53-8189-4989-8dd1-4e38f28f7f5e of > task '34ddb6bc-bf93-42ff-aab1-cb06d25c5fc6' in state TASK_FINISHED exited > with status 0 > I0609 18:16:12.575960 22694 default_executor.cpp:945] Terminating after 1secs > [ OK ] HostNetwork/DefaultExecutorCniTest.ROOT_VerifyContainerIP/0 > (2366 ms) > [----------] 1 test from HostNetwork/DefaultExecutorCniTest (2368 ms total) > > [----------] 1 test from CniNetwork/DefaultExecutorCniTest > [ RUN ] CniNetwork/DefaultExecutorCniTest.ROOT_VerifyContainerIP/0 > I0609 18:16:13.042444 22763 executor.cpp:192] Version: 1.4.0 > I0609 18:16:13.059947 22759 default_executor.cpp:182] Received SUBSCRIBED > event > I0609 18:16:13.065265 22759 default_executor.cpp:186] Subscribed executor on > centos7 > I0609 18:16:13.065783 22759 default_executor.cpp:182] Received LAUNCH_GROUP > event > W0609 18:16:13.067163 22763 default_executor.cpp:443] Setting > `MESOS_CONTAINER_IP` to: 10.0.2.15 > I0609 18:16:13.181131 22765 default_executor.cpp:605] Successfully launched > tasks [ 1d265a47-6422-458e-b350-9a1091130c40 ] in child containers [ > 48fc4118-8637-4564-9a8f-73de5712e277.69464142-e313-4c8e-859c-cd1d2cce4e26 ] > I0609 18:16:13.183614 22764 default_executor.cpp:678] Waiting for child > container > 48fc4118-8637-4564-9a8f-73de5712e277.69464142-e313-4c8e-859c-cd1d2cce4e26 of > task '1d265a47-6422-458e-b350-9a1091130c40' > I0609 18:16:13.191012 22760 default_executor.cpp:182] Received ACKNOWLEDGED > event > I0609 18:16:13.290139 22763 default_executor.cpp:823] Child container > 48fc4118-8637-4564-9a8f-73de5712e277.69464142-e313-4c8e-859c-cd1d2cce4e26 of > task '1d265a47-6422-458e-b350-9a1091130c40' in state TASK_FINISHED exited > with status 0 > I0609 18:16:13.290249 22763 default_executor.cpp:945] Terminating after 1secs > [ OK ] CniNetwork/DefaultExecutorCniTest.ROOT_VerifyContainerIP/0 (728 > ms) > [----------] 1 test from CniNetwork/DefaultExecutorCniTest (729 ms total) > > [----------] Global test environment tear-down > [==========] 2 tests from 2 test cases ran. (3105 ms total) > [ PASSED ] 2 tests. > > > Thanks, > > Avinash sridharan > >
