----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60184/#review178238 -----------------------------------------------------------
src/common/resources.cpp Line 2221 (original), 2202 (patched) <https://reviews.apache.org/r/60184/#comment252116> Why don't we check `role` is optional? Because we assume the "new" post-refined format is used? It would be great if we can somehow express that `type` and `role` are kinda required in the new format. - Alexander Rukletsov On June 19, 2017, 5:26 a.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60184/ > ----------------------------------------------------------- > > (Updated June 19, 2017, 5:26 a.m.) > > > Review request for mesos and Neil Conway. > > > Bugs: MESOS-7655 > https://issues.apache.org/jira/browse/MESOS-7655 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/common/resources.cpp cc305e64cadc9fab913ede987625fc1839646306 > src/v1/resources.cpp 03d6c8098a24a2751617d14f2664de1d88318414 > > > Diff: https://reviews.apache.org/r/60184/diff/1/ > > > Testing > ------- > > > Thanks, > > Michael Park > >
