----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60281/#review178623 -----------------------------------------------------------
src/master/master.cpp Line 4558 (original), 4558 (patched) <https://reviews.apache.org/r/60281/#comment252729> If we're already copying the operation (see `foreach` a few lines up), do we need to make an additional copy of the `TaskInfo`? If we mutate w/o copying, we'd avoid the need to introduce a second variable. - Neil Conway On June 21, 2017, 7:06 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60281/ > ----------------------------------------------------------- > > (Updated June 21, 2017, 7:06 p.m.) > > > Review request for mesos and Neil Conway. > > > Repository: mesos > > > Description > ------- > > Since we drop invalid tasks on a `LAUNCH` operation, we send a new > `Operation` with only the valid tasks appended. At the same time, > we adjust the `TaskInfo` a little bit to perform validation, and > to maintain backwards compatibility. In the end, we were appending > the unadjusted task to the new `Operation` rather than the adjusted > task. This patch changes this to append the adjusted task instead. > > > Diffs > ----- > > src/master/master.cpp ec594a8f4fa95e77fc38103c5561d1797fe2b133 > > > Diff: https://reviews.apache.org/r/60281/diff/1/ > > > Testing > ------- > > > Thanks, > > Michael Park > >
