----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60405/#review178834 -----------------------------------------------------------
Just a couple of clarifying questions before we commit these comments. src/messages/messages.proto Line 436 (original), 439-442 (patched) <https://reviews.apache.org/r/60405/#comment253085> Since this is a `repeated Resource` list, is it possible that some resources in the list are pre-format and some are post? Or will they all be post if any resource has a refinement? src/slave/slave.cpp Lines 1405-1407 (original), 1405-1408 (patched) <https://reviews.apache.org/r/60405/#comment253086> If this agent has refinements, and we send post format to an old master, will the old master safely reject the registration, crash and burn, or something in between? src/slave/slave.cpp Line 1408 (original), 1412-1414 (patched) <https://reviews.apache.org/r/60405/#comment253087> We could at least log an INFO/WARN if we aren't able to downgrade, and still send it anyway. - Adam B On June 23, 2017, 6:48 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60405/ > ----------------------------------------------------------- > > (Updated June 23, 2017, 6:48 p.m.) > > > Review request for mesos, Adam B and Michael Park. > > > Repository: mesos > > > Description > ------- > > Documented resource format in agent <-> master protocol. > > > Diffs > ----- > > src/messages/messages.proto 2c086263fdcee4d54a76a61379c2d4dba5271d23 > src/slave/slave.cpp f808458849bb9667a91abe18868751d377d36e0c > > > Diff: https://reviews.apache.org/r/60405/diff/2/ > > > Testing > ------- > > > Thanks, > > Neil Conway > >
