> On June 26, 2017, 11:40 a.m., Benjamin Bannier wrote:
> > support/post-reviews.py
> > Line 48 (original), 69 (patched)
> > <https://reviews.apache.org/r/60233/diff/1/?file=1754211#file1754211line73>
> >
> > Do we need to name the exception here? It seems the original `raise`
> > was sufficient.
>
> Armand Grillet wrote:
> I cannot just do an `except:` above or PyLint returns `W: 66, 4: No
> exception type(s) specified (bare-except)`. I have changed the code to have a
> `except Exception as _:` followed by just a `raise`.
I didn't mean to catch all exceptions, we should still be specific, but
wouldn't need to name the exception, e.g.,
try:
foo()
except Exception:
raise
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60233/#review178874
-----------------------------------------------------------
On June 26, 2017, 5:46 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60233/
> -----------------------------------------------------------
>
> (Updated June 26, 2017, 5:46 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Joseph Wu.
>
>
> Bugs: MESOS-6390
> https://issues.apache.org/jira/browse/MESOS-6390
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This will allow us to use PyLint on the
> entire support directory in the future.
>
>
> Diffs
> -----
>
> support/post-reviews.py 410fb3371a3c46adbfd68c7584ffd6cf3b3010d1
>
>
> Diff: https://reviews.apache.org/r/60233/diff/2/
>
>
> Testing
> -------
>
> Added `support` to `source_dirs` in the PyLinter defined
> in `mesos-style.py`. Linted until only acceptable errors
> where displayed (e.g. due to the name of the file containing
> a dash instead of an underscore).
>
>
> Thanks,
>
> Armand Grillet
>
>
