> On June 27, 2017, 10:29 a.m., Benjamin Mahler wrote:
> > It's ok for now, but our current approach means that only the help 
> > endpoints for those components that are run as part of this script will 
> > show up. So for example, if the cgroups isolator exposes some endpoints 
> > these will not be published to the website. I think longer term if we have 
> > the help stored in markdown we can avoid this issue.

Can you add a comment about it needing to work within docker hence the flags?


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60438/#review178969
-----------------------------------------------------------


On June 26, 2017, 5:54 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60438/
> -----------------------------------------------------------
> 
> (Updated June 26, 2017, 5:54 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and haosdent huang.
> 
> 
> Bugs: MESOS-7625
>     https://issues.apache.org/jira/browse/MESOS-7625
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Changed agent flags to make this script work inside Docker container.
> This is needed because this script will be run as part of website
> publishing process which runs on ASF CI inside Docker.
> 
> 
> Diffs
> -----
> 
>   support/generate-endpoint-help.py 6eb2d41b35c5f064839c29a0ba8326c590a33213 
> 
> 
> Diff: https://reviews.apache.org/r/60438/diff/1/
> 
> 
> Testing
> -------
> 
> Tested by running a CI job pointing to a branch containing this patch.
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Reply via email to