> On July 7, 2017, 7:26 a.m., James Peach wrote:
> > docs/upgrades.md
> > Line 331 (original), 332 (patched)
> > <https://reviews.apache.org/r/60639/diff/2/?file=1770557#file1770557line332>
> >
> > You need a blank line after the link target or the bullet point won't
> > render.
> >
> > Also, "Changes to capability-related agent flags".
Thanks for catching this, I messed that up while rebasing.
I originally had a patch to change the formatting of all preceeding bullet
points (misformated or not) to be along the lines of
* <a name="foo"></a>
Text for this bullet point comes here.
but I see that you already cleaned this up to be consistent with the sections
added earlier. The advantage of above pattern is that the anchor would be
placed inside the bullet point, and not before it as currently. I believe this
would be closer to the intention. Do you think it would make sense to adjust
the anchors?
Ironic that I broke this myself now :|
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60639/#review179847
-----------------------------------------------------------
On July 6, 2017, 6:34 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60639/
> -----------------------------------------------------------
>
> (Updated July 6, 2017, 6:34 p.m.)
>
>
> Review request for mesos, Benjamin Mahler, Jie Yu, and Jan Schlicht.
>
>
> Bugs: MESOS-7755
> https://issues.apache.org/jira/browse/MESOS-7755
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added MESOS-7755 to the upgrades guide.
>
>
> Diffs
> -----
>
> docs/upgrades.md 60d55259d5bed5dbdad5c7f79e7d998af425b0b1
>
>
> Diff: https://reviews.apache.org/r/60639/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
