----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60326/#review180077 -----------------------------------------------------------
I'm going to rewrite this a bit because of the below: 3rdparty/stout/include/stout/os/raw/argv.hpp Lines 42-47 (original), 42-48 (patched) <https://reviews.apache.org/r/60326/#comment255083> Considering how there's already a conversion from `Iterable` to `std::vector<char*>`, this function can be cleaned up a bit. We can convert from `Iterable` to `std::vector<std::string>` instead. And the `char** argv` can point to the C-strings of that vector. - Joseph Wu On June 21, 2017, 3:11 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60326/ > ----------------------------------------------------------- > > (Updated June 21, 2017, 3:11 p.m.) > > > Review request for mesos, Alexander Rukletsov, Jeff Coffler, John Kordich, > Joseph Wu, Li Li, and Michael Park. > > > Bugs: MESOS-6817, MESOS-7371 and MESOS-7407 > https://issues.apache.org/jira/browse/MESOS-6817 > https://issues.apache.org/jira/browse/MESOS-7371 > https://issues.apache.org/jira/browse/MESOS-7407 > > > Repository: mesos > > > Description > ------- > > This is needed for implementations that expect a `vector<string>` > instead of a `char **`. > > > Diffs > ----- > > 3rdparty/stout/include/stout/os/raw/argv.hpp > 58e5ee2a0ae6a68b3221124f196f0e650c32a8c0 > > > Diff: https://reviews.apache.org/r/60326/diff/1/ > > > Testing > ------- > > > Thanks, > > Andrew Schwartzmeyer > >
