-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60846/
-----------------------------------------------------------
(Updated July 15, 2017, 12:37 a.m.)
Review request for mesos, Gilbert Song and Jie Yu.
Changes
-------
Refactored.
Summary (updated)
-----------------
Retry logic for unsuccessful `docker rm` during agent recovery.
Bugs: MESOS-7777
https://issues.apache.org/jira/browse/MESOS-7777
Repository: mesos
Description (updated)
-------
This patch skips all failures returned from `Docker::rm` during agent
recovery, then schedule retries with an exponential backoff, and go
ahead to unmount the persistent volumes for all Docker containers.
The unit test `DockerContainerizerTest.ROOT_DOCKER_RecoverWithRmFails`
mocks `Docker::rm` to return 4 failures before actually perform
`docker rm` to test if the exponential backoff works correctly.
Diffs (updated)
-----
src/slave/constants.hpp 435c37e28987119c4ef43c9dad61ac052020acd8
src/slave/containerizer/docker.cpp 2fe92272d7ac6d916371c55affe24598255f10eb
src/slave/flags.hpp bf9adf03847a113306c1df2d71e839b90ada7dd3
src/slave/flags.cpp a4c1a0c62af5506bbeb1d26d2fd9ca0ba11d8ad7
src/tests/containerizer/docker_containerizer_tests.cpp
1e85a79f812399270575ea4a64db10e72f40e648
Diff: https://reviews.apache.org/r/60846/diff/4/
Changes: https://reviews.apache.org/r/60846/diff/3-4/
Testing
-------
sudo make check
Thanks,
Chun-Hung Hsiao
