----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60400/#review180779 -----------------------------------------------------------
Fix it, then Ship it! Ship It! src/master/master.cpp Lines 6185 (patched) <https://reviews.apache.org/r/60400/#comment256009> s/regsitering/reregistering/ src/master/master.cpp Lines 6206 (patched) <https://reviews.apache.org/r/60400/#comment256013> I think this would be clearer with an if/else. ``` if (slaves.recovered.contains(...)) { ... readmit } else { ... update registry readmit } ``` - James Peach On July 13, 2017, 11:01 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60400/ > ----------------------------------------------------------- > > (Updated July 13, 2017, 11:01 p.m.) > > > Review request for mesos, Benjamin Mahler, James Peach, and Neil Conway. > > > Bugs: MESOS-7711 > https://issues.apache.org/jira/browse/MESOS-7711 > > > Repository: mesos > > > Description > ------- > > Skipped consulting registry if the agent is in the `slaves.recovered`. > > > Diffs > ----- > > src/master/master.cpp d895154c00eef17511c46ddd0b75922f952707eb > > > Diff: https://reviews.apache.org/r/60400/diff/2/ > > > Testing > ------- > > make check. > > Will add more tests. > > > Thanks, > > Jiang Yan Xu > >
