----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60991/#review181020 -----------------------------------------------------------
Ship it! Ship It! - Qian Zhang On July 20, 2017, 8:16 a.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60991/ > ----------------------------------------------------------- > > (Updated July 20, 2017, 8:16 a.m.) > > > Review request for mesos, haosdent huang, Jason Lai, Jie Yu, Qian Zhang, and > Zhongbo Tian. > > > Repository: mesos > > > Description > ------- > > A device in cgroup can be represented as either a path or a major:minor > number. Need to change the `required` Device::path to `optional` to > add Number in the device protobuf. > > > Diffs > ----- > > include/mesos/mesos.proto ab2a372184b7cfbaf7a38e90f487cba38c3e80b8 > include/mesos/v1/mesos.proto 5e92e5d86023ad6edd94303fbde964bf403abf02 > src/slave/containerizer/mesos/isolators/cgroups/subsystems/devices.cpp > ddf2a4d661001a3a5832c21504420223ca60a753 > > > Diff: https://reviews.apache.org/r/60991/diff/1/ > > > Testing > ------- > > make > > > Thanks, > > Gilbert Song > >
