> On July 17, 2017, 11:50 p.m., Jie Yu wrote: > > src/resource_provider/manager.cpp > > Lines 134 (patched) > > <https://reviews.apache.org/r/60771/diff/1/?file=1774138#file1774138line134> > > > > Can we use `Owned` pointer here so that you don't need to release them > > in destructor.
Instead of `Owned` I'm now using `ResourceProvider` instances directly instead of pointers. - Jan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60771/#review180219 ----------------------------------------------------------- On July 24, 2017, 2:07 p.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60771/ > ----------------------------------------------------------- > > (Updated July 24, 2017, 2:07 p.m.) > > > Review request for mesos, Benjamin Bannier and Jie Yu. > > > Bugs: MESOS-7780 > https://issues.apache.org/jira/browse/MESOS-7780 > > > Repository: mesos > > > Description > ------- > > Using HTTP, resource providers are expected to subscribe to the resource > provider manager. The resource provider manager will assign a unique ID > to subscribed resource providers and use events to communicate with > them. > > > Diffs > ----- > > src/resource_provider/manager.cpp a9bf258a0896bd519b99a689a0bfab64d665172f > src/tests/resource_provider_http_api_tests.cpp > 46a3f37ba046201e9d79e8ba037da2cb37f5c31f > > > Diff: https://reviews.apache.org/r/60771/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
