----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60931/#review181254 -----------------------------------------------------------
Mostly some comments around using the `/teardown` endpoint to trigger the `FRAMEWORK_REMOVED` event. It's mostly due to the fact that we don't yet support updating `FrameworkInfo` for some fields due to https://issues.apache.org/jira/browse/MESOS-703 (and is not supported well). src/tests/api_tests.cpp Lines 1925-1927 (patched) <https://reviews.apache.org/r/60931/#comment256779> s/is able/can to be consistent with the agent test. src/tests/api_tests.cpp Lines 1935 (patched) <https://reviews.apache.org/r/60931/#comment256780> Kill this comment; its self-explanatory. src/tests/api_tests.cpp Lines 1963 (patched) <https://reviews.apache.org/r/60931/#comment256781> Kill this. src/tests/api_tests.cpp Lines 1979 (patched) <https://reviews.apache.org/r/60931/#comment256784> How about: ```cpp // Start a scheduler. The subscriber should receive a `FRAMEWORK_ADDED` event when the scheduler subscribes with the master. ``` src/tests/api_tests.cpp Lines 1985-1987 (patched) <https://reviews.apache.org/r/60931/#comment256786> hmm, can you just set this to a larger value (ideally a week) since the framework can be removed due to the failover timeout happening upon a disconnection! src/tests/api_tests.cpp Lines 1992 (patched) <https://reviews.apache.org/r/60931/#comment256787> Why do you need the `WillRepeatedly` here? src/tests/api_tests.cpp Lines 2009-2010 (patched) <https://reviews.apache.org/r/60931/#comment256785> Kill this; since we included the info above. src/tests/api_tests.cpp Lines 2050 (patched) <https://reviews.apache.org/r/60931/#comment256788> How about: ```cpp Force a reconnection with the master. This should result in a `FRAMEWORK_UPDATED` event when the scheduler re-registers with the master. ``` src/tests/api_tests.cpp Lines 2060-2062 (patched) <https://reviews.apache.org/r/60931/#comment256789> Kill this. Let's send a request to the `/teardown` endpoint to tear-down the framework and use that to verify the `FRAMEWORK_REMOVED` event. - Anand Mazumdar On July 18, 2017, 12:29 a.m., Quinn Leng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60931/ > ----------------------------------------------------------- > > (Updated July 18, 2017, 12:29 a.m.) > > > Review request for mesos, Anand Mazumdar, Greg Mann, and Zhitao Li. > > > Bugs: MESOS-6101 > https://issues.apache.org/jira/browse/MESOS-6101 > > > Repository: mesos > > > Description > ------- > > Added test cases for 'FRAMEWORK_ADDED', 'FRAMEWORK_UPDATED' and > 'FRAMEWORK_REMOVED' events in v1 operator API. > > > Diffs > ----- > > src/tests/api_tests.cpp f22ca28c819712d8797e0c0c69dc1ebf1fe5ac1f > > > Diff: https://reviews.apache.org/r/60931/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Quinn Leng > >
