-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61109/
-----------------------------------------------------------

Review request for mesos, Benjamin Mahler and James Peach.


Bugs: MESOS-7828
    https://issues.apache.org/jira/browse/MESOS-7828


Repository: mesos


Description
-------

Used the default value when parsing an optional enum field.


Diffs
-----

  3rdparty/stout/include/stout/protobuf.hpp 
15690b66cc4ae0c1bf2c2176d73c385ca75d3c20 


Diff: https://reviews.apache.org/r/61109/diff/1/


Testing
-------

With this patch, when accessing master endpoint with an inexistent enum `xxx` 
in a JSON:
```
curl -X POST -H "Content-Type: application/json" -d '{"type": "xxx"}' 
127.0.0.1:5050/api/v1
```
The master log will be:
```
I0725 23:09:53.097790   665 http.cpp:1133] HTTP POST for /master/api/v1 from 
127.0.0.1:49566 with User-Agent='curl/7.47.0'
I0725 23:09:53.098006   665 http.cpp:669] Processing call UNKNOWN
```
This proves when parsing an inexistent enum the default enum value (i.e., 
`UNKNOWN`) will be used.


Thanks,

Qian Zhang

Reply via email to