----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60961/#review181465 -----------------------------------------------------------
Patch looks great! Reviews applied: [61124, 60957, 61125, 60958, 60959, 61126, 61127, 60960, 60961] Passed command: support\windows-build.bat - Mesos Reviewbot Windows On July 19, 2017, 8:59 a.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60961/ > ----------------------------------------------------------- > > (Updated July 19, 2017, 8:59 a.m.) > > > Review request for mesos, Benjamin Mahler, Kevin Klues, and Jiang Yan Xu. > > > Bugs: MESOS-6918 > https://issues.apache.org/jira/browse/MESOS-6918 > > > Repository: mesos > > > Description > ------- > > Added support for using a `format=prometheus` query parameter > to the `/metrics/snapshot` endpoint to emit metrics in native > Prometheus format. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/metrics/metrics.hpp > 9c32a88d851c884a5025edb6ea1e27939b484546 > 3rdparty/libprocess/src/metrics/metrics.cpp > 7184aa4d0294c20466646c9aa61d90973eca22e1 > 3rdparty/libprocess/src/tests/metrics_tests.cpp > 161ca0dc7aea526d450d71a80839d8cc075aaa31 > > > Diff: https://reviews.apache.org/r/60961/diff/5/ > > > Testing > ------- > > make check (Fedora 26). Manual testing with Prometheus 2.0beta. > > > Thanks, > > James Peach > >
