> On July 3, 2017, 5:15 p.m., haosdent huang wrote: > > Should we make `support/mesos-website/entrypoint.sh` support a environment > > variable `MODE=dev` and then we `export MODE=dev` in > > `site/mesos-website-dev.sh` and just call `support/mesos-website.sh`? It > > would help to avoid write duplicate code in different places.
There are some differences between the publish and dev workflows: -- "publish" Dockerfile needs deps that are needed to build mesos and generate endpoint doc in addition to generating website. -- "dev" Dockerfile only needs deps for generating the website. -- In "dev" workflow the developer is expected to build mesos and generate endpoint docs outside the Dockefile; this is it allow fast iteration. For example if a developer is only making changes to docs or website pages, no need to re-build mesos and endpoint docs. -- `docker run` command params are slightly different because dev workflow needs interactive mode and ports exposed -- `build.sh` script is different for each workflow because of the first 2 points. -- `entrypoint.sh` script is different for each workflow because of the discrepancies between how Docker works on Linux and MacOS. I agree that we should ideally merge the two workflows to avoid code duplication or as Bannier suggested below to just get rid of Docker for dev workflow. I'm actually in favor of the latter unless there is a strong reason to use docker for the dev workflow. If we agree on that I can update this patch. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60440/#review179519 ----------------------------------------------------------- On June 29, 2017, 9:59 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60440/ > ----------------------------------------------------------- > > (Updated June 29, 2017, 9:59 p.m.) > > > Review request for mesos, Benjamin Bannier, Benjamin Mahler, and haosdent > huang. > > > Bugs: MESOS-7625 > https://issues.apache.org/jira/browse/MESOS-7625 > > > Repository: mesos > > > Description > ------- > > Made the layout and scripts consistent with CI based automatic > publishing of the website. > > > Diffs > ----- > > site/Dockerfile 8ba0be0c28e924f7a2b89e6e5a3237deb3751a41 > site/README.md ebd3e6a0fea7ae0fe3b28719bcab28ee8f7c356c > site/build.sh 11f15e15621c4d3db1472e88911787b9b3100f97 > site/entrypoint.sh PRE-CREATION > site/mesos-website-dev.sh PRE-CREATION > > > Diff: https://reviews.apache.org/r/60440/diff/1/ > > > Testing > ------- > > Tested by running the script locally. > > > Thanks, > > Vinod Kone > >
