----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60784/#review181632 -----------------------------------------------------------
Ship it! I spent a while trying to come up with a good test case, but unfortunately the resources-related operators as written don't make this easy. Code LGTM, let's go ahead and ship it. - Greg Mann On July 11, 2017, 10:29 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60784/ > ----------------------------------------------------------- > > (Updated July 11, 2017, 10:29 p.m.) > > > Review request for mesos and Greg Mann. > > > Repository: mesos > > > Description > ------- > > The previous implementation was incorrect for the case when either > `right.path` or `right.mount` is set but the corresponding field in > `left` is unset. > > > Diffs > ----- > > src/common/resources.cpp 3f4fff4f1dbe9c8acc55e3077212fe329e53e4d9 > src/v1/resources.cpp 55d493e89114acc94b1524f3f94a47ccea20469a > > > Diff: https://reviews.apache.org/r/60784/diff/1/ > > > Testing > ------- > > `make check` > > I tried to write a unit test for this specific problem but wasn't able to > repro :-\ Current coding seems wrong / inconsistent in any case, though. > > > Thanks, > > Neil Conway > >
