> On July 26, 2017, 11:08 a.m., Ilya Pronin wrote: > > src/tests/containerizer/linux_filesystem_isolator_tests.cpp > > Lines 252-255 (patched) > > <https://reviews.apache.org/r/61123/diff/1/?file=1782381#file1782381line252> > > > > Why do we need Docker for this test? The problem should be reproducible > > without it. > > Ilya Pronin wrote: > I meant an image. Not Docker itself :) > > Gilbert Song wrote: > We don't allow `host_path` and `container_path` to be both relative. > > > https://github.com/apache/mesos/blob/master/src/slave/containerizer/mesos/isolators/filesystem/linux.cpp#L453~#L460 > > Ilya Pronin wrote: > Yeah, but in the test you're mounting relative `host_path` (`tmp`) to > absolute `container_path` (`/tmp`), aren't you?
if we dont have an image specified (no rootfs), then the absolute container_path must be existed in the host. Compared to mounting something to the host, let's mount it to the container. - Gilbert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61123/#review181467 ----------------------------------------------------------- On July 27, 2017, 6:47 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61123/ > ----------------------------------------------------------- > > (Updated July 27, 2017, 6:47 p.m.) > > > Review request for mesos, Ilya Pronin, Jie Yu, James Peach, Stephan Erb, > Vinod Kone, and Jiang Yan Xu. > > > Bugs: MESOS-5187 > https://issues.apache.org/jira/browse/MESOS-5187 > > > Repository: mesos > > > Description > ------- > > Added regression test for sandbox volume ownership issue. > > > Diffs > ----- > > src/tests/containerizer/linux_filesystem_isolator_tests.cpp > 457311e23a0c848ef3ed69c8be4396e6a01f3b95 > > > Diff: https://reviews.apache.org/r/61123/diff/2/ > > > Testing > ------- > > make check > > Verified that this test failed if we don't have the bugfix patch. > > > Thanks, > > Gilbert Song > >
