----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61182/#review181734 -----------------------------------------------------------
src/resource_provider/message.hpp Lines 29 (patched) <https://reviews.apache.org/r/61182/#comment257385> With ERP in mind, maybe it's more approapriate to make this message for a single resource provider? For instance: ``` struct ResourceProviderMessage { enum class Type { UPDATE_TOTAL_RESOURCES, }; struct UpdateTotalResources { Option<ResourceProviderID> id; Resources total; }; Type type; UpdateTotalResources updateTotalResources; }; ``` - Jie Yu On July 27, 2017, 2:49 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61182/ > ----------------------------------------------------------- > > (Updated July 27, 2017, 2:49 p.m.) > > > Review request for mesos, Jie Yu and Jan Schlicht. > > > Bugs: MESOS-7837 > https://issues.apache.org/jira/browse/MESOS-7837 > > > Repository: mesos > > > Description > ------- > > In order to inform users of resource provider managers that the > managed resources have changed, we add a new 'ResourceProviderMessage' > type for communicating changes to the managed total resources. > > We add code to trigger sending of that message when a resource > provider subscribes with the manager. > > In the future this message could also be used to communicate changes > to an already subscribed resource provider's total resources. > > > Diffs > ----- > > src/Makefile.am 5712bad2acc4cf0f8ec9b7febffcdb0fa77578c9 > src/resource_provider/manager.cpp 44e1576d4462295d404429d51682134306047462 > src/resource_provider/message.hpp 916926bf278de9ed919384a82a452d3ced06bd04 > src/tests/CMakeLists.txt 6dd2716de942adf6cefa5a464ef664f3c3ebb7a3 > src/tests/resource_provider_http_api_tests.cpp > 85906ea5e1bb3516ef264de22913ce0a3c9c58c5 > src/tests/resource_provider_manager_tests.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/61182/diff/1/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
