----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61112/#review181892 -----------------------------------------------------------
Fix it, then Ship it! I will fix the outstanding issues and commit this for you. src/examples/balloon_framework.cpp Lines 46 (patched) <https://reviews.apache.org/r/61112/#comment257681> Looks like we should `#include <stout/protobuf.hpp>` instead of this file. src/examples/balloon_framework.cpp Line 109 (original), 114 (patched) <https://reviews.apache.org/r/61112/#comment257682> Let's mention this flag is deprecated. src/examples/balloon_framework.cpp Lines 118-124 (patched) <https://reviews.apache.org/r/61112/#comment257684> For consistency, with other JSON flags, how about this: ``` "The value could be a JSON-formatted string of `URI`s that\n" "should be fetched before running the executor, or a file\n" "path containing the JSON-formatted `URI`s. Path must be of\n" "the form `file:///path/to/file` or `/path/to/file`.\n" "This flag replaces `--executor_uri`.\n" "See the `CommandInfo::URI` message in `mesos.proto` for the\n" "expected format.\n" ``` src/examples/balloon_framework.cpp Lines 133-135 (original), 159-161 (patched) <https://reviews.apache.org/r/61112/#comment257685> Add a TODO for deprecation: ``` // TODO(armand): Remove the `--executor_uri` flag after the // deprecation cycle, started in 1.4.0. ``` src/examples/balloon_framework.cpp Line 500 (original), 533-534 (patched) <https://reviews.apache.org/r/61112/#comment257686> Blank line, please. - Alexander Rukletsov On Aug. 1, 2017, 10:20 a.m., Armand Grillet wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61112/ > ----------------------------------------------------------- > > (Updated Aug. 1, 2017, 10:20 a.m.) > > > Review request for mesos, Alexander Rukletsov and Till Toenshoff. > > > Bugs: MESOS-7814 > https://issues.apache.org/jira/browse/MESOS-7814 > > > Repository: mesos > > > Description > ------- > > Allows to set URIs that will be fetched before running the executor. > > > Diffs > ----- > > src/examples/balloon_framework.cpp b8c8e387bd8592bc1d27ff62fa9fd5397ad71fb9 > src/examples/long_lived_framework.cpp > af5b43ee6994cf703f412436d6d561d9abd3b26d > > > Diff: https://reviews.apache.org/r/61112/diff/3/ > > > Testing > ------- > > $ make check > > > Thanks, > > Armand Grillet > >
