> On Aug. 7, 2017, 9:34 p.m., Greg Mann wrote: > > src/linux/ns.hpp > > Lines 538-539 (original), 585-586 (patched) > > <https://reviews.apache.org/r/61476/diff/1/?file=1790944#file1790944line585> > > > > Should this comment be removed? > > Greg Mann wrote: > Sorry, I mean maybe it should be updated to mention 'clone' instead of > 'fork'?
I'd prefer we still keep the name `fork` here. The reason we use a clone to mimic a fork is due to a glibc bug. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61476/#review182325 ----------------------------------------------------------- On Aug. 7, 2017, 8:02 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61476/ > ----------------------------------------------------------- > > (Updated Aug. 7, 2017, 8:02 p.m.) > > > Review request for mesos, Benjamin Hindman, Benjamin Mahler, and Joseph Wu. > > > Bugs: MESOS-7858 > https://issues.apache.org/jira/browse/MESOS-7858 > > > Repository: mesos > > > Description > ------- > > Used clone instead of fork in ns::clone. > > > Diffs > ----- > > src/linux/ns.hpp 941c7ee243e0e486ee263a9e6c4f6d0a7398427d > > > Diff: https://reviews.apache.org/r/61476/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
