----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61597/ -----------------------------------------------------------
(Updated Aug. 11, 2017, 4:27 p.m.) Review request for mesos, Jeff Coffler and Joseph Wu. Summary (updated) ----------------- Fixed linking to `IPHlpAPI` library. Bugs: MESOS-7704 https://issues.apache.org/jira/browse/MESOS-7704 Repository: mesos Description ------- While the `#pragma comment(lib...)` method works with MSVC, it is inconsistent with how we link to the rest of the Windows libraries. So it was deleted and `IPHlpAPI` was added to stout's Windows dependencies. Furthermore, the `<iphlpapi.h>` header was removed from the individual files and placed in `windows.hpp` to ensure it is included in the correct order with respect to the other Windows headers. Diffs ----- 3rdparty/stout/CMakeLists.txt 76b2a67419cb6836b598a0070f26632d4ca048ff 3rdparty/stout/include/stout/windows.hpp 92db7278aea5cc9b94bec77071b9803f58042624 3rdparty/stout/include/stout/windows/ip.hpp 76f23c823662a54162e64160980512b191bb88e8 3rdparty/stout/include/stout/windows/mac.hpp 09c4c9626d135705a502b6d148f5b6ba64b688cd 3rdparty/stout/include/stout/windows/net.hpp 1418b5c981a2286c9ae390d801a8021e3a442f5b Diff: https://reviews.apache.org/r/61597/diff/1/ Testing ------- stout-tests on Windows Thanks, Andrew Schwartzmeyer