----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61574/#review182904 -----------------------------------------------------------
src/tests/containerizer.hpp Lines 168 (patched) <https://reviews.apache.org/r/61574/#comment258847> s/status/signal/ src/tests/containerizer.cpp Lines 534-541 (patched) <https://reviews.apache.org/r/61574/#comment258848> Can you do this inside `TestContainerizerProcess::kill` instead of here? Seems more consistent with how we handled `attach` for example. - Vinod Kone On Aug. 10, 2017, 7:32 p.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61574/ > ----------------------------------------------------------- > > (Updated Aug. 10, 2017, 7:32 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-7879 > https://issues.apache.org/jira/browse/MESOS-7879 > > > Repository: mesos > > > Description > ------- > > This is needed to make some tests pass that rely on the test > containerizer. > > > Diffs > ----- > > src/tests/containerizer.hpp 4bd40c32625bc1f7998d523c6ee81bf78ac74538 > src/tests/containerizer.cpp 1d2b6391cf7a7545fa44206c59d05764f3e8cdfb > > > Diff: https://reviews.apache.org/r/61574/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Anand Mazumdar > >
