> On Aug. 9, 2017, 5:30 p.m., Avinash sridharan wrote: > > docs/health-checks.md > > Lines 204 (patched) > > <https://reviews.apache.org/r/61434/diff/1/?file=1789488#file1789488line204> > > > > I think we also need to mention that the expectation here is that task > > is listening on the `loopback` interface along with any other routeable > > interface to which it might be listening.
Good idea. > On Aug. 9, 2017, 5:30 p.m., Avinash sridharan wrote: > > docs/health-checks.md > > Line 265 (original), 494 (patched) > > <https://reviews.apache.org/r/61434/diff/1/?file=1789488#file1789488line517> > > > > Why do we need to share the `mnt` namespace? This is already done by > > the executor for `MesosContainerizer` so why does the `checker` need to do > > this if it is running as part of the executor? Nope, not for the command executor case when `rootfs` is specified. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61434/#review182495 ----------------------------------------------------------- On Aug. 11, 2017, 12:12 a.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61434/ > ----------------------------------------------------------- > > (Updated Aug. 11, 2017, 12:12 a.m.) > > > Review request for mesos, Gastón Kleiman, Greg Mann, and Vinod Kone. > > > Bugs: MESOS-7349 > https://issues.apache.org/jira/browse/MESOS-7349 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > docs/health-checks.md d0749347d1f9398004e56b03503d655b5fba75f4 > > > Diff: https://reviews.apache.org/r/61434/diff/2/ > > > Testing > ------- > > https://gist.github.com/rukletsov/517a136cb6a0e8b909db30b36b13eded > > Additionally rendered in MacDown. > > > Thanks, > > Alexander Rukletsov > >
