> On Aug. 15, 2017, 10:47 a.m., Andrew Schwartzmeyer wrote: > > Ship It!
You can remove the "depends on 60345" here to make the bot a bit happier. - Andrew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60620/#review182962 ----------------------------------------------------------- On July 5, 2017, 10:43 a.m., Jeff Coffler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60620/ > ----------------------------------------------------------- > > (Updated July 5, 2017, 10:43 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and > Li Li. > > > Bugs: MESOS-6705 > https://issues.apache.org/jira/browse/MESOS-6705 > > > Repository: mesos > > > Description > ------- > > Modify os::write to write binary files on Windows. > > > Diffs > ----- > > 3rdparty/stout/include/stout/os/write.hpp > beb5bd83b52565a75e34d32b5bb17951bc799578 > > > Diff: https://reviews.apache.org/r/60620/diff/2/ > > > Testing > ------- > > Built successfully on both Linux (with autotools and cmake) and Windows (with > cmake). > > Ran stout-tests and mesos-tests successfully on both Windows and Linux. > > > Thanks, > > Jeff Coffler > >