----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61189/#review183028 -----------------------------------------------------------
Bad patch! Reviews applied: [61189] Failed command: python support/apply-reviews.py -n -r 61189 Error: error: patch failed: src/master/http.cpp:826 error: src/master/http.cpp: patch does not apply error: patch failed: src/tests/api_tests.cpp:1921 error: src/tests/api_tests.cpp: patch does not apply Full log: http://mesos-winbot.westus.cloudapp.azure.com/logs/235/console - Mesos Reviewbot Windows On July 27, 2017, 6:25 p.m., Quinn Leng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61189/ > ----------------------------------------------------------- > > (Updated July 27, 2017, 6:25 p.m.) > > > Review request for mesos, Anand Mazumdar, Alexander Rojas, and Greg Mann. > > > Bugs: MESOS-7785 > https://issues.apache.org/jira/browse/MESOS-7785 > > > Repository: mesos > > > Description > ------- > > Added authorization filtering for V1 streaming events, the > subscriber should only receive events that are authorized > based on their principal and ACLs. > > > Diffs > ----- > > src/master/http.cpp 9df086c417a9392f62d600c7a6486be0a1cf7e70 > src/master/master.hpp 84465af782d4024f22463d981ef9d0ef7827d043 > src/master/master.cpp e12c997dad04f8a4ddb47a993a84b2b05c9e2f32 > src/tests/api_tests.cpp f22ca28c819712d8797e0c0c69dc1ebf1fe5ac1f > > > Diff: https://reviews.apache.org/r/61189/diff/2/ > > > Testing > ------- > > make check > GLOG_v=2 ./bin/mesos-tests.sh > --gtest_filter="ContentType/MasterAPITest.EventsAuthorizationFiltering*" > --verbose --gtest_repeat=100 --gtest_break_on_failure > > > Thanks, > > Quinn Leng > >
