> On Aug. 17, 2017, 10:45 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/ports.cpp > > Lines 156-157 (patched) > > <https://reviews.apache.org/r/60496/diff/10/?file=1797108#file1797108line156> > > > > Do we really need this? I think showing pid like what you did in the > > `else` block below should be enough. > > James Peach wrote: > Yes, I think this is definitely needed in order to understand why the > isolator is killing processes. Any time you need to debug what is getting > killed this will make is much easier to understand.
OK, then I think here in the `if` block we'd better to log pid as well, we should provide as much userful info as possible for user to debug. - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60496/#review182691 ----------------------------------------------------------- On Aug. 18, 2017, 1:36 a.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60496/ > ----------------------------------------------------------- > > (Updated Aug. 18, 2017, 1:36 a.m.) > > > Review request for mesos, Qian Zhang and Jiang Yan Xu. > > > Bugs: MESOS-7675 > https://issues.apache.org/jira/browse/MESOS-7675 > > > Repository: mesos > > > Description > ------- > > Implemented ports resource restrictions in the network ports isolator. > Periodically, scan for listening sockets and match them up to all > the open sockets in the containers we are tracking in the network. > Check any sockets we find against the ports resource and trigger a > resource limitation if the port has not been allocated. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/network/ports.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/network/ports.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/60496/diff/11/ > > > Testing > ------- > > make check (Fedora 26) > > > Thanks, > > James Peach > >
