----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61642/#review183492 -----------------------------------------------------------
Fix it, then Ship it! src/slave/slave.hpp Lines 854 (patched) <https://reviews.apache.org/r/61642/#comment259509> I think "active" here might be misleading; we don't remove the framework if tasks/executors have been terminated but acks have not been received. How about: // Returns whether the framework all the frameworks's tasks and executors have completed, // i.e., terminated and in case of tasks, also received acknowledgements for all pending updates. Still debating whether "idle" is a better word than "empty" - Vinod Kone On Aug. 15, 2017, 7 a.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61642/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2017, 7 a.m.) > > > Review request for mesos, Anand Mazumdar and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > This ensures the call-sites consistently check idleness of the > framework, it also aids readability in that it clarifies that > we remove idle frameworks. > > > Diffs > ----- > > src/slave/slave.hpp 1fe93dab1b2bef24721cc1bcffebe1b259e96d79 > src/slave/slave.cpp 7381530515f86faf4c3e8f82bcd9483f6cf0498b > > > Diff: https://reviews.apache.org/r/61642/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Mahler > >
