----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61650/#review183556 -----------------------------------------------------------
Fix it, then Ship it! src/slave/slave.hpp Lines 715 (patched) <https://reviews.apache.org/r/61650/#comment259578> Can you add a comment that this also adds the task to queued tasks? src/slave/slave.cpp Lines 2399 (patched) <https://reviews.apache.org/r/61650/#comment259576> s/task/tasks/ src/slave/slave.cpp Lines 2619 (patched) <https://reviews.apache.org/r/61650/#comment259577> can you log the task or taskgroup for debugging? - Vinod Kone On Aug. 15, 2017, 7 a.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61650/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2017, 7 a.m.) > > > Review request for mesos, Anand Mazumdar and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > With this patch, the enqueueing and dequeueing of tasks in the > agent are controlled solely by Executor class member functions, > which simplifies the agent code. > > > Diffs > ----- > > src/slave/slave.hpp 1fe93dab1b2bef24721cc1bcffebe1b259e96d79 > src/slave/slave.cpp 7381530515f86faf4c3e8f82bcd9483f6cf0498b > > > Diff: https://reviews.apache.org/r/61650/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Mahler > >
