> On Aug. 22, 2017, 10:46 a.m., Alexander Rukletsov wrote: > > 3rdparty/stout/include/stout/os/write.hpp > > Lines 67 (patched) > > <https://reviews.apache.org/r/61797/diff/1/?file=1801032#file1801032line68> > > > > `std::strlen`? > > Andrei Budnik wrote: > I'm not sure if `std::strlen` is async-signal safe. > > Alexander Rukletsov wrote: > It is the same function but properly namespaced.
Ok. Fixed. - Andrei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61797/#review183460 ----------------------------------------------------------- On Aug. 21, 2017, 8:54 p.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61797/ > ----------------------------------------------------------- > > (Updated Aug. 21, 2017, 8:54 p.m.) > > > Review request for mesos, Alexander Rukletsov, Alexander Rojas, Benjamin > Bannier, Benjamin Mahler, and James Peach. > > > Bugs: MESOS-7791 > https://issues.apache.org/jira/browse/MESOS-7791 > > > Repository: mesos > > > Description > ------- > > Async-signal safe `write` function, which can take variable number of > arguments, should be used to improve signal safety. > > > Diffs > ----- > > 3rdparty/stout/include/stout/abort.hpp > d3291dce8ec3db6141124e9cd231d34409998a18 > 3rdparty/stout/include/stout/os/write.hpp > beb5bd83b52565a75e34d32b5bb17951bc799578 > > > Diff: https://reviews.apache.org/r/61797/diff/3/ > > > Testing > ------- > > sudo make check (mac os x, fedora 25) > internal CI > > > Thanks, > > Andrei Budnik > >
