----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61893/#review183801 -----------------------------------------------------------
Fix it, then Ship it! src/tests/gc_tests.cpp Line 1007 (original), 1007 (patched) <https://reviews.apache.org/r/61893/#comment259847> Clean up the comment a bit: "*that* the path removal *that* failed" doesn't sound right? - Jiang Yan Xu On Aug. 24, 2017, 12:34 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61893/ > ----------------------------------------------------------- > > (Updated Aug. 24, 2017, 12:34 p.m.) > > > Review request for mesos, Jie Yu and Jiang Yan Xu. > > > Repository: mesos > > > Description > ------- > > If we fail to garbage collect a path, verify that the failure is > recorded but don't depend on how many failures we encounter. This > ensures that we check what is important but don't bind to specific > values in a brittle wway. > > > Diffs > ----- > > src/tests/gc_tests.cpp f451b2c4e2a4c8a6337216f0f0cde894f00c7d09 > > > Diff: https://reviews.apache.org/r/61893/diff/1/ > > > Testing > ------- > > make check && sudo make check (Fedora 26) > > > Thanks, > > James Peach > >