----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61849/#review183858 -----------------------------------------------------------
src/master/main.cpp Line 138 (original), 138 (patched) <https://reviews.apache.org/r/61849/#comment259922> Should we update this comment? src/slave/main.cpp Line 231 (original), 231 (patched) <https://reviews.apache.org/r/61849/#comment259920> Should we update this comment as well? - Andrei Budnik On Aug. 23, 2017, 2:21 p.m., Armand Grillet wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61849/ > ----------------------------------------------------------- > > (Updated Aug. 23, 2017, 2:21 p.m.) > > > Review request for mesos, Andrei Budnik and Alexander Rukletsov. > > > Bugs: MESOS-7586 > https://issues.apache.org/jira/browse/MESOS-7586 > > > Repository: mesos > > > Description > ------- > > The main functions now have a common pattern, in 6 steps: > 1. Load flags. > 2. Check if the --help flag has been passed. > 3. Check if the flags are correct. > 4. Initialize logging. > 5. Parse and setup the environment variables. > 6. Initialize libprocess. > > This change reduces the number of messages "WARNING: Logging > before InitGoogleLogging() is written to STDERR" as we use > glog only after the fourth step in the modified files. > > > Diffs > ----- > > src/docker/executor.cpp 99a62244b7805d25b926d0293cb62574981d2878 > src/launcher/default_executor.cpp 30bae5c931c81b81ff9590eea8051b2232388813 > src/launcher/executor.cpp 65b9a2c52ba5a5a514fff992018e356f388468fc > src/local/main.cpp f0d7e8ca1a64b5409632ea0c0894a1dc84f9796e > src/master/main.cpp 1a78a55fd52c5eebad689c2a7f16c95979260d79 > src/slave/main.cpp a4a8ced6825ece1b25003824d987ff83fb799ad7 > > > Diff: https://reviews.apache.org/r/61849/diff/2/ > > > Testing > ------- > > ``` > $ make check > ``` > > > Thanks, > > Armand Grillet > >
