> On Aug. 30, 2017, 9:41 p.m., Gastón Kleiman wrote: > > src/tests/default_executor_tests.cpp > > Lines 1419 (patched) > > <https://reviews.apache.org/r/61981/diff/3/?file=1808295#file1808295line1419> > > > > This future isn't needed, waiting for `subscribed` bellow should be > > enough.
Keep it the same as others in this file since it ssems more explicitly to await for the connection ready first. > On Aug. 30, 2017, 9:41 p.m., Gastón Kleiman wrote: > > src/tests/default_executor_tests.cpp > > Lines 1455 (patched) > > <https://reviews.apache.org/r/61981/diff/3/?file=1808295#file1808295line1455> > > > > This should be an assertion instead of an expectation. Good catch. - Gilbert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61981/#review184235 ----------------------------------------------------------- On Aug. 30, 2017, 4:45 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61981/ > ----------------------------------------------------------- > > (Updated Aug. 30, 2017, 4:45 p.m.) > > > Review request for mesos, Benjamin Hindman, Benjamin Mahler, Jie Yu, and Qian > Zhang. > > > Bugs: MESOS-7926 > https://issues.apache.org/jira/browse/MESOS-7926 > > > Repository: mesos > > > Description > ------- > > Added unit test for killing the default executor process. > > > Diffs > ----- > > src/tests/default_executor_tests.cpp > afe0afabf784fb65eb833beadd3c584722c321e1 > > > Diff: https://reviews.apache.org/r/61981/diff/3/ > > > Testing > ------- > > > Thanks, > > Gilbert Song > >
