----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62106/ -----------------------------------------------------------
Review request for mesos, Andrew Schwartzmeyer, Jeff Coffler, and Joseph Wu. Bugs: MESOS-3384 https://issues.apache.org/jira/browse/MESOS-3384 Repository: mesos Description ------- Enabled CRAM MD5 Authentication on Windows and associated tests. Diffs ----- cmake/CompilationConfigure.cmake 4cb8dddf93694722af2377c4a55a195260c8a0cb docs/windows.md b47ba5a0db3d41d6f4bb002283b40622a2bb3e0f src/CMakeLists.txt 1a828c4351ded36f51ccbbe67147da2f50b9cdb1 src/authentication/cram_md5/authenticatee.cpp 7b3f767e29163de489018081089e67a6f22971c5 src/authentication/cram_md5/authenticator.cpp 2a12bb3f4aec79056ec6c82a8c896ee3af15bb4c src/authentication/cram_md5/auxprop.hpp dedcbe514283dd86a924d92ccdd17173ebe878cb src/tests/CMakeLists.txt def233d13f627f58362fdc61ac3e9c104d65fe7e src/tests/authentication_tests.cpp b04be76d23788fbde337eaf85716ec7436ade691 Diff: https://reviews.apache.org/r/62106/diff/1/ Testing ------- Ran the automake build and the cmake build on Linux, as well as the cmake build on Windows, with no errors. Ran tests on both platforms as well. Note: The mesos-3rdparty pull request which contains the cyrus-sasl package needs to be merged to master first before these patches will work. (Or, have the cyrus-sasl tarball available in a local 3rdparty directory, configured with mesos) Thanks, John Kordich