----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62105/#review184912 -----------------------------------------------------------
3rdparty/CMakeLists.txt Lines 193-195 (patched) <https://reviews.apache.org/r/62105/#comment261112> We should actually call the target `sasl2` so that its target name matches that used on Linux. Our goal is that this section of code contains all the necessary data to build and link to `sasl2`, such that any other target which needs to link to it can simply do `target_link_libraries(mesos PUBLIC sasl2)`. This can be acheived by keeping the target name identical, and setting the compilation definitions as public properties here. - Andrew Schwartzmeyer On Sept. 6, 2017, 6:11 p.m., John Kordich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62105/ > ----------------------------------------------------------- > > (Updated Sept. 6, 2017, 6:11 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Jeff Coffler, and Joseph Wu. > > > Bugs: MESOS-3384 > https://issues.apache.org/jira/browse/MESOS-3384 > > > Repository: mesos > > > Description > ------- > > Enabled building of the Cyrus SASL CRAM MD5 lib on Windows. > > > Diffs > ----- > > 3rdparty/CMakeLists.txt 2a183a4a46bf8bc97455fe02648407ba561b38e7 > 3rdparty/cmake/Versions.cmake 0b62ae96817ade616f8dfc52cf8df995f8fd8927 > 3rdparty/cyrus_sasl-2.1.27rc3.patch PRE-CREATION > > > Diff: https://reviews.apache.org/r/62105/diff/3/ > > > Testing > ------- > > > Thanks, > > John Kordich > >
