----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62230/#review185123 -----------------------------------------------------------
src/slave/gc.cpp Lines 231 (patched) <https://reviews.apache.org/r/62230/#comment261350> I was suggesting using this: https://github.com/apache/mesos/blob/master/3rdparty/libprocess/include/process/executor.hpp as a helper actor with the same lifecycle as the gc actor, and we dispatch all rmdirs onto that actor. We did the previous patch precisely to avoid dispatching onto the gc actor itself because the rmdirs could block new task launches. - Jiang Yan Xu On Sept. 11, 2017, 2:39 p.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62230/ > ----------------------------------------------------------- > > (Updated Sept. 11, 2017, 2:39 p.m.) > > > Review request for mesos, Benjamin Mahler, Jie Yu, and Jiang Yan Xu. > > > Bugs: MESOS-7964 > https://issues.apache.org/jira/browse/MESOS-7964 > > > Repository: mesos > > > Description > ------- > > This patch dispatches GC pruning events to `GarbageCollectorProcess` > instead of multiple `AsyncExecutor`s such that if multiple heavy-duty > pruning events won't occupy all worker threads and block other actors. > > > Diffs > ----- > > src/slave/gc.cpp 83e4e2f3aba5c0d9900cf0beeea6e92320f889e7 > > > Diff: https://reviews.apache.org/r/62230/diff/1/ > > > Testing > ------- > > sudo make test > > > Thanks, > > Chun-Hung Hsiao > >
