> On Sept. 2, 2017, 6:27 p.m., Jie Yu wrote: > > This might need to be adjusted based on this: > > https://github.com/container-storage-interface/spec/pull/97 > > > > so `id` should be string, and `metadata` is labels given the above PR goes > > through
Like you suggested below, I moved `id` to `Source`, and also added a `metadata` field. While `id` is considered when evaluating identity in the matrix you gave above, `metadata` just participates via equality. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58048/#review184432 ----------------------------------------------------------- On Sept. 12, 2017, 3:14 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58048/ > ----------------------------------------------------------- > > (Updated Sept. 12, 2017, 3:14 p.m.) > > > Review request for mesos, Jie Yu and Jan Schlicht. > > > Bugs: MESOS-7312 > https://issues.apache.org/jira/browse/MESOS-7312 > > > Repository: mesos > > > Description > ------- > > Ids will allow to create distinguishable resources, e.g., of RAW or > BLOCK type. We also add a metadata field which can be used to expose > additional disk information. > > > Diffs > ----- > > include/mesos/mesos.proto fa475dcc3aa0b15ee4b2b740a24ab3c0b9a3274c > include/mesos/v1/mesos.proto dfba4181203e23f7eedf67c19379d031e0993fd5 > src/common/resources.cpp 14b600ca1577be4910164396c75b866b53439ade > src/tests/resources_tests.cpp 8a86efe60024d9e36294f0acb3f43bdd3f52f5bc > src/v1/resources.cpp a5cc15591b7611274148139c43465adae44c1dbb > > > Diff: https://reviews.apache.org/r/58048/diff/5/ > > > Testing > ------- > > make check (OS X, Fedora25) > > > Thanks, > > Benjamin Bannier > >
